Skip to content

ci(nav3): [Part 12] Keep compatibility coverage current - #6709

Open
0xadam-brown wants to merge 1 commit into
feat/nav3-serial-name-mappers-11from
feat/nav3-serial-name-mappers-12
Open

0xadam-brown wants to merge 1 commit into
feat/nav3-serial-name-mappers-11from
feat/nav3-serial-name-mappers-12

Conversation

@0xadam-brown

@0xadam-brown 0xadam-brown commented Nov 20, 2026 •

Copy link
Copy Markdown
Member

PR Stack (Nav3 Serial Name Mappers)


📜 Description

Keeps Nav3’s R8 compatibility tests current by checking for kotlinx.serialization releases weekly and proposing updates to the newer runtime tested alongside the supported floor.

💡 Motivation and Context

The properties mapper uses serialization’s experimental encoding API, and host apps determine which runtime it runs against. Exercising newer releases in R8-minified apps helps catch API and shrinker-rule incompatibilities before the next SDK release, without raising the SDK’s minimum supported version.

addresses: JAVA-787 (link)

💚 How did you test it?

n/a

📝 Checklist

  • I added GH Issue ID & Linear ID
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.
  • Public API changes reviewed by another Mobile SDK team member or implemented according to the develop docs spec.

🔮 Next steps

Once the numbered slices have been reviewed and merged into the collection branch, review the aggregate change and squash-merge the collection PR into main.

⚠️ Merge this PR using a merge commit (not squash). Only the collection branch is squash-merged into main.

#skip-changelog

@github-actions

github-actions Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

PR risk: medium

For commit 08d30db.

The model rated this change low. It was raised to medium because:

  • R6: build or release configuration changed: .github/workflows/update-deps.yml, scripts/update-nav3-kotlinx-serialization.sh
  • R7: the model was not confident enough that the change is low

This label is a hint for reviewers, not an approval.

@github-actions github-actions Bot added risk: medium PR risk score: medium and removed risk: medium PR risk score: medium labels Nov 20, 2026
@sentry

sentry Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

📲 Install Builds

Android

🔗 App Name App ID Version Configuration
SDK Size io.sentry.tests.size 8.65.0 (1) release

⚙️ sentry-android Build Distribution Settings

@0xadam-brown
0xadam-brown force-pushed the feat/nav3-serial-name-mappers-11 branch from 5ddd798 to 7d85cf6 Compare November 20, 2026 14:00
@0xadam-brown
0xadam-brown force-pushed the feat/nav3-serial-name-mappers-12 branch from a3da611 to 08d30db Compare November 20, 2026 14:00
@github-actions github-actions Bot added risk: medium PR risk score: medium and removed risk: medium PR risk score: medium labels Nov 20, 2026
@0xadam-brown 0xadam-brown changed the title ci(nav3): [Nav3 Mappers 12] Keep compatibility coverage current ci(nav3): [Part 12] Keep compatibility coverage current Nov 20, 2026
@0xadam-brown
0xadam-brown marked this pull request as ready for review November 20, 2026 16:07
@0xadam-brown
0xadam-brown requested review from a team and adinauer as code owners November 20, 2026 16:07
@0xadam-brown
0xadam-brown requested review from markushi and romtsn and removed request for a team November 20, 2026 16:07
@github-actions github-actions Bot removed the risk: medium PR risk score: medium label Nov 20, 2026
@github-actions github-actions Bot added the risk: medium PR risk score: medium label Nov 20, 2026
@0xadam-brown 0xadam-brown added the sanity-check PR needs a lightweight review for obvious issues label Nov 20, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 08d30db. Configure here.

name: Nav3 kotlinx.serialization R8 check
# Only the R8 verification app uses this version; the SDK's dependency doesn't change.
changelog-entry: false
ssh-key: ${{ secrets.CI_DEPLOY_KEY }}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prerelease tags can stall version updates

Medium Severity

The nav3 updater omits pattern, so kotlinx.serialization RC tags are treated as latest. get-version and set-version only match [0-9.]+ before a quote, so once defaultLatestKotlinx is an RC those commands stop matching and the pin cannot move to the later stable tag.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 08d30db. Configure here.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk: medium PR risk score: medium sanity-check PR needs a lightweight review for obvious issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant